Feature actuator disk with variable load #1027
Conversation
EttoreSaetta
changed the title
|
Ettore,
Thanks for submitting this. I thought you gave an excellent presentation at the SU2 Conference and the much better actuator disk model you and your colleagues have put together will surely be useful to many people.
Thanks for participating and being a member of the SU2 Community. Please stay healthy and well and I hope to meet you in person next time we have a meeting (fingers crossed….maybe next year?).
Best wishes,
Juan
… On Jun 18, 2020, at 1:27 AM, SaettaE ***@***.***> wrote:
Proposed Changes
Addition of a new actuator disk model with a variable load and swirl distributions along disk radius.
Contributors:
Theoretical and Applied Aerodynamic Research Group (TAARG) of University of Naples Federico II.
EttoreSaetta, lorenzorusso07, rtogna.
Related Work
Introduction of new options in the config. file.
Introduction of an additional input file that contains the propeller data.
Introduction of additional c++ functions.
Addition of code lines to existing functions preserving the original actuator disk model.
PR Checklist
[X ] I am submitting my contribution to the develop branch.
My contribution generates no new compiler warnings (try with the '-Wall -Wextra -Wno-unused-parameter -Wno-empty-body' compiler flags).
[ X] My contribution is commented and consistent with SU2 style.
I have added a test case that demonstrates my contribution, if necessary.
I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp) , if necessary.
You can view, comment on, or merge this pull request online at:
#1027 <#1027>
Commit Summary
Update config_template.cfg
File Changes
M config_template.cfg <https://github.com/su2code/SU2/pull/1027/files#diff-2c2f226c0183e7633cf165c6d3862450> (5)
Patch Links:
https://github.com/su2code/SU2/pull/1027.patch <https://github.com/su2code/SU2/pull/1027.patch>
https://github.com/su2code/SU2/pull/1027.diff <https://github.com/su2code/SU2/pull/1027.diff>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#1027>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA5FFRGLBAHYBVTV3GBSLATRXHFYXANCNFSM4OBLB3CQ>.
|
Thank you very much, I hope we can give an useful contribution. Best regards, |
Data file for the actuator disk with variable load test case.
Hello @pcarruscag, Have a nice day, |
pcarruscag
left a comment
pcarruscag
left a comment
There was a problem hiding this comment.
Awesome, thanks. Couple more things I noticed.
There was a problem hiding this comment.
Thank you for the changes LGTM, it would be nice if that section of code that does the reading could go to a separate function, unless it needs a lot of the information available where you have it now.
Let's try and get another review so that this PR can be merged before #1044.
Yes, we planned to put that piece of code into a separate function tomorrow. So I will try and push a commit for another review tomorrow. |
|
Thank you for the review @pcarruscag. |
|
Anytime. |
Proposed Changes
Addition of a new actuator disk model with a variable load and swirl distributions along disk radius.
Contributors:
Theoretical and Applied Aerodynamic Research Group (TAARG) of University of Naples Federico II.
EttoreSaetta, lorenzorusso07, rtogna.
Related Work
Introduction of new options in the config. file.
Introduction of an additional input file that contains the propeller data.
Introduction of additional c++ functions.
Addition of code lines to existing functions preserving the original actuator disk model.
PR Checklist